From cea1423109c61f229e61b88a3b7ac9829e661574 Mon Sep 17 00:00:00 2001
From: nickpons666 <miguel.a.pons@protonmail.com>
Date: Fri, 9 Jan 2026 16:20:51 -0600
Subject: [PATCH] =?UTF-8?q?fix(productos):=20Resuelve=20m=C3=BAltiples=20e?=
 =?UTF-8?q?rrores=20de=20variables=20undefined=20y=20validaci=C3=B3n?=
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

- Arregla variable \$_GET["p"] con null coalescing
- Implementa paginación completa en EnumDuplicados()
- Agrega validación isset() en templates para evitar null access
- Mejora validación de entradas GET
- Corrige inicialización de variables en templates

Resuelve errores masivos y warnings en módulo de productos.
---
 classes/producto.class.php            | 10 ++++++++++
 modules/productos-duplicados.php      |  2 +-
 templates/forms/search-productos.tpl  | 18 ++++++++++++++----
 templates/lists/enumProdCatSearch.tpl |  2 +-
 4 files changed, 26 insertions(+), 6 deletions(-)

diff --git a/classes/producto.class.php b/classes/producto.class.php
index aef78e8..f116962 100755
--- a/classes/producto.class.php
+++ b/classes/producto.class.php
@@ -321,6 +321,16 @@ class Producto extends Main
 	
 	function EnumDuplicados()
 	{		
+		$db = $this->Util()->DBSelect($_SESSION["empresaId"]);
+		
+		$sql = "SELECT COUNT(*) FROM producto WHERE codigoBarra LIKE '%-%'";
+		$db->setQuery($sql);
+		$total = $db->GetSingle();
+
+		$pages = $this->Util()->HandleMultipages($this->page, $total ,WEB_ROOT."/productos-duplicados", "p");
+
+		$sqlAdd = "LIMIT ".$pages["start"].", ".$pages["items_per_page"];
+		
 		$sql = "SELECT *						
 				FROM producto
 				WHERE codigoBarra LIKE '%-%'
diff --git a/modules/productos-duplicados.php b/modules/productos-duplicados.php
index fb3c2de..a1cdcf1 100755
--- a/modules/productos-duplicados.php
+++ b/modules/productos-duplicados.php
@@ -2,7 +2,7 @@
 
     $empresa->AuthUser();
 			
-	$producto->SetPage($_GET["p"]);
+	$producto->SetPage($_GET["p"] ?? 1);
 	$productos = $producto->EnumDuplicados();
 	
 	$items = array();
diff --git a/templates/forms/search-productos.tpl b/templates/forms/search-productos.tpl
index 91eabfc..a5e561b 100755
--- a/templates/forms/search-productos.tpl
+++ b/templates/forms/search-productos.tpl
@@ -19,13 +19,23 @@
     <td align="center">
     	 <select name="proveedorId2" id="proveedorId2" class="largeInput">
             <option value="">Seleccione</option>
-            {foreach from=$proveedores item=item key=key}
-            <option value="{$item.proveedorId}" {if $info.proveedorId == $item.proveedorId}selected{/if}>{$item.nombre|truncate:25:"..."}</option>
-            {/foreach}
+{if isset($proveedores) && count($proveedores) > 0}
+            {if isset($proveedores) && count($proveedores) > 0}
+    {foreach from=$proveedores item=item key=key}
+        <option value="{$item.proveedorId}" {if isset($info.proveedorId) && $info.proveedorId == $item.proveedorId}selected{/if}>{$item.nombre}</option>
+    {/foreach}
+    {else}
+        <option value="">No hay proveedores disponibles</option>
+    {/if}
+        {else}
+            <option value="">No hay proveedores disponibles</option>
+        {/if}
         </select>
     </td>
   	<td align="center">
-    	{include file="{$DOC_ROOT}/templates/lists/enumProdCatSearch.tpl"}
+    	{if isset($categorias) && count($categorias) > 0}
+    {include file="{$DOC_ROOT}/templates/lists/enumProdCatSearch.tpl"}
+    {/if}
     </td>
     <td align="center">                 
      <input type="text" size="35" name="word" id="word" class="largeInput" onkeyup="CheckKey(event)" style="width:180px" />     
diff --git a/templates/lists/enumProdCatSearch.tpl b/templates/lists/enumProdCatSearch.tpl
index 7949cc0..bfa5bea 100755
--- a/templates/lists/enumProdCatSearch.tpl
+++ b/templates/lists/enumProdCatSearch.tpl
@@ -1,6 +1,6 @@
  <select name="idProdCat" id="idProdCat" class="largeInput wide2">
     <option value="">Todos</option>
     {foreach from=$categorias item=item key=key}
-    <option value="{$item.prodCatId}" {if $info.prodCatId == $item.prodCatId}selected{/if}>{$item.nombre}</option>
+    <option value="{$item.prodCatId}" {if isset($info.prodCatId) && $info.prodCatId == $item.prodCatId}selected{/if}>{$item.nombre}</option>
     {/foreach}
 </select>
\ No newline at end of file